Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set readOnlyPort to 0 #390

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Set readOnlyPort to 0 #390

merged 1 commit into from
Jun 8, 2020

Conversation

Pluies
Copy link
Contributor

@Pluies Pluies commented Jan 8, 2020

*Issue

#99

Description of changes:

See CIS Benchmark 4.2.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Set readOnlyPort to 0
943ca2b 
See CIS Benchmark 4.2.4
@Pluies Pluies mentioned this pull request Jan 8, 2020
Merged
mogren
mogren approved these changes Jan 10, 2020
View reviewed changes
Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

max-lobur
max-lobur approved these changes Apr 10, 2020
View reviewed changes
Copy link

@max-lobur max-lobur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkarklinsScout
Copy link

Is there anything else that needs to be addressed here, or are we good to merge this in?

@abeer91
Copy link
Contributor

abeer91 commented Jun 8, 2020

From my understanding of this change and testing, this is more for completeness. Looking at this old discussion #128 we had already disabled this port. I tried this on a current ami by running

[ec2-user@ip-192-168-169-67 ~]$ curl localhost:10255/stats/summary -v
*   Trying 127.0.0.1...
* TCP_NODELAY set
* connect to 127.0.0.1 port 10255 failed: Connection refused
* Failed to connect to localhost port 10255: Connection refused
* Closing connection 0
curl: (7) Failed to connect to localhost port 10255: Connection refused

@abeer91 abeer91 merged commit 2e1f63f into awslabs:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@mogren mogren mogren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pluies @mkarklinsScout @abeer91 @mogren @max-lobur