Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eventRecordQPS to 0 #391

Closed
wants to merge 1 commit into from
Closed

Set eventRecordQPS to 0 #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions files/kubelet-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"hairpinMode": "hairpin-veth",
"cgroupDriver": "cgroupfs",
"cgroupRoot": "/",
"eventRecordQPS": 0,
Copy link

@joebowbeer joebowbeer Sep 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eventRecordQPS": 0,

Nope. This would be unlimited, which the CIS Benchmark warns against.

Unfortunately, the CIS Benchmark is terribly confused in what it does recommend, but that is its problem.

To understand the current snafu, start by looking at the source code that implemented the deprecated --event-qps flag. It is this flag to which the CIS Benchmark recommendation originally applied, and for this flag a setting of 0 would be interpreted the same as if the flag were omitted, and the effective QPS would be 5, which is the default value for eventRecordQPS.

Then the flag was deprecated.

Unfortunately, setting eventRecordQPS=0 is explicitly disabling any rate limiting, whereas omitting eventRecordQPS will result in the default value 5.

"featureGates": {
"RotateKubeletServerCertificate": true
},
Expand Down