Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMI release to get Cluster DNS IP from SCIDR for Self Managed Nodegroups #525

Merged
merged 1 commit into from
Aug 20, 2020
Merged

AMI release to get Cluster DNS IP from SCIDR for Self Managed Nodegroups #525

merged 1 commit into from
Aug 20, 2020

Conversation

ljosyula
Copy link
Contributor

Issue:
Getting Cluster DNS IP from SCIDR for Self Managed Nodegroups, when DNS IP is not provided by user. This is being done as a part of SCIDR Feature Launch

Description of changes:
Added a code to find SCIDR from Describe Cluster and assign DNS IP using that. This is done as a part of new SCIDR feature, where we allow user to give SCIDR value as well. For Mnaged Nodegroups this is handles in ISO. For unmanaged nodegroups we are handling it by creating a new AMI version. If the SCIDR is given then the Cluster DNS IP is set using that. To make it backward compatible, if SCIDR is null DNS IP will be set 10... or 172... depending on the vpc-ipv4-cidr-blocks as it was happening earlier.

Testing:
Since the feature is not launched yet. I added the service model in the nodegroup created during testing by : aws configure add-model
Created a file in the nodegroup that holds the value of SCIDR fetched from Describe Cluster API and DNS Cluster IP.
Created a cluster with SCIDR, then created a Self managed nodegroup with new Service Model loaded in it and one with current API.
Created a cluster and Self managed nodegroup in external-client-account as well to test backward compatibility

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ljosyula ljosyula marked this pull request as draft August 20, 2020 17:11
@ljosyula ljosyula marked this pull request as ready for review August 20, 2020 17:11
@ljosyula ljosyula marked this pull request as draft August 20, 2020 17:12
@ljosyula ljosyula marked this pull request as ready for review August 20, 2020 17:14
@blxdaniel blxdaniel requested a review from abeer91 August 20, 2020 17:31
@abeer91 abeer91 merged commit 8864821 into awslabs:master Aug 20, 2020
@dgr237
Copy link

dgr237 commented Aug 27, 2020

This change has broken any users which are not using managed node groups and are running in a private vpc i.e. we pass the ca bundle and the endpoint but not the DNS IP as we want the bootstrap.sh to calculate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants