AMI release to get Cluster DNS IP from SCIDR for Self Managed Nodegroups #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Getting Cluster DNS IP from SCIDR for Self Managed Nodegroups, when DNS IP is not provided by user. This is being done as a part of SCIDR Feature Launch
Description of changes:
Added a code to find SCIDR from Describe Cluster and assign DNS IP using that. This is done as a part of new SCIDR feature, where we allow user to give SCIDR value as well. For Mnaged Nodegroups this is handles in ISO. For unmanaged nodegroups we are handling it by creating a new AMI version. If the SCIDR is given then the Cluster DNS IP is set using that. To make it backward compatible, if SCIDR is null DNS IP will be set 10... or 172... depending on the vpc-ipv4-cidr-blocks as it was happening earlier.
Testing:
Since the feature is not launched yet. I added the service model in the nodegroup created during testing by : aws configure add-model
Created a file in the nodegroup that holds the value of SCIDR fetched from Describe Cluster API and DNS Cluster IP.
Created a cluster with SCIDR, then created a Self managed nodegroup with new Service Model loaded in it and one with current API.
Created a cluster and Self managed nodegroup in external-client-account as well to test backward compatibility
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.