Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerd runtime support #698

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Containerd runtime support #698

merged 3 commits into from
Jul 13, 2021

Conversation

ravisinha0506
Copy link
Contributor

Issue #, if available:

Description of changes:
changes done to add support for containerd runtime in eks worker ami. This is done by:

  • Adding a new optional parameter to specify container-runtime in the bootstrap script.
  • The default value of this parameter is dockerd to make it backward compatible to existing behavior.
  • docker process wouldn't be running on the host when containerd runtime is chosen on the node.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fi
systemctl daemon-reload
systemctl enable docker
systemctl start docker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
In the previous version of this file the Docker daemon was always restarted after its config file was modified. But after this commit nothing happens, the changes don't have an effect, probably because now the script runs systemctl start docker instead of systemctl restart docker

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is impacting our automated testing too. Was wondering what the rationale between switching from restart to start was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants