Updated dependency versions #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
reviewed
Jun 3, 2021
README.md
Outdated
Comment on lines
148
to
149
| * Updated to version 2.3.4 of the Amazon Kinesis Client Library for Java. | ||
| * Upgraded multiple dependencies |
There was a problem hiding this comment.
We should make release notes / dependency upgrades separate PRS, and we should link PRS once they're merged in so customers can reference them in release notes. As part of the release PR, we also need to update versioning for this package's release.
Also, we need to get these release notes approved by doc writer.
There was a problem hiding this comment.
Also good to list what dependencies were upgraded specifically (i.e AWS SDK, Jackson, etc.)
|
How did we test this? |
|
Tested by running the sample https://github.com/awslabs/amazon-kinesis-client-python#running-the-sample. Was able to successfully write and read records from Kinesis Stream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.