Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable property option to use AT_TIMESTAMP shard iterator in MultiLangDaemon clients #341

Closed
marcinc opened this issue May 25, 2018 · 1 comment
Labels
v1.x Issues related to the 1.x version
Milestone

Comments

@marcinc
Copy link
Contributor

marcinc commented May 25, 2018

Since support for Time based shard iterators was added in #94, it would be good to enable option to pass initial timestamp for AT_TIMESTAMP iterator from properties file. This would enable Multilang Daemon clients to take advantage of this iterator type. This was previously requested in #145.

It looks like it could be achieved by simply adding appropriate Date parameter type decoder in KinesisClientLibConfigurator which would then allow use of the following property:

# app.properties

timestampAtInitialPositionInStream = 1527254694

Internally this would result in correct setting of initialPositionInStream to AT_TIMESTAMP and its initial timestamp to 1527254694.

marcinc added a commit to marcinc/amazon-kinesis-client that referenced this issue May 25, 2018
marcinc added a commit to marcinc/amazon-kinesis-client that referenced this issue May 25, 2018
marcinc added a commit to marcinc/amazon-kinesis-client that referenced this issue May 29, 2018
@pfifer pfifer added this to the v1.9.2 milestone May 29, 2018
@pfifer pfifer added the v1.x Issues related to the 1.x version label Sep 4, 2018
@pfifer
Copy link
Contributor

pfifer commented Sep 4, 2018

This should be fixed in 1.9.2 and should be available in Maven over the next 24 hours.

Feel free to reopen if you run into the issue again.

@pfifer pfifer closed this as completed Sep 4, 2018
pfifer added a commit to pfifer/amazon-kinesis-client that referenced this issue Sep 5, 2018
pfifer added a commit that referenced this issue Sep 5, 2018
pfifer added a commit that referenced this issue Sep 10, 2018
* Fix link to issue #341

* Fix the link in the changelog too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.x Issues related to the 1.x version
Projects
None yet
Development

No branches or pull requests

2 participants