Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AFTER_SEQUENCE_NUMBER iterator type for expired iterator request #1014

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

cylee99
Copy link
Contributor

@cylee99 cylee99 commented Dec 14, 2022

Issue #, if available:

Description of changes:

Updating the restartIterator logic in the KinesisDataFetcher class to use AFTER_SEQUENCE_NUMBER iterator call to prevent the last retrieved record from being retrieved again when the iterator expires.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@zengyu714 zengyu714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyu714 zengyu714 merged commit 17d0940 into awslabs:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants