Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplication of project version in children pom.xml #1045

Merged

Conversation

ZeyuLi-AWS
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Removed explicit project version in children pom.xml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stair-aws stair-aws added the v2.x Issues related to the 2.x version label Feb 17, 2023
Copy link
Contributor

@stair-aws stair-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified "it blends", but recommend renaming the property to eliminate ambiguity.

@ZeyuLi-AWS Thanks for removing the duplication!

pom.xml Show resolved Hide resolved
@ZeyuLi-AWS ZeyuLi-AWS merged commit 70cfc7d into awslabs:master Feb 20, 2023
@ZeyuLi-AWS ZeyuLi-AWS deleted the Explicitize-version-in-parent-pom branch February 20, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.x Issues related to the 2.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants