Allow leader to learn new leases upon re-election to avoid unnecessary shardSyncs #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stair-aws
reviewed
Mar 14, 2023
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/SchedulerTest.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/SchedulerTest.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java
Show resolved
Hide resolved
abhit17
reviewed
Mar 14, 2023
amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java
Show resolved
Hide resolved
stair-aws
previously approved these changes
Mar 14, 2023
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/SchedulerTest.java
Show resolved
Hide resolved
stair-aws
approved these changes
Mar 15, 2023
amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java
Show resolved
Hide resolved
chenylee-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upon leader change the new leader might not have the latest streams in its in-memory map therefore would enqueue shardSyncs for these streams. It can be a waste if the shardSyncs result in no leases created as they have been created by the previous leader. Instead, we should fast forward and sync the leaders in-memory map upon leader change and let the
PeriodicShardSyncManagerto take care of updating the new streams by first checking the hash range completion before deciding to enqueuing them for shardSyncs to save IOPs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.