Added metrics in ShutdownTask for scenarios when parent leases are …
#1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing. + optimizations in `ShutdownTask` (e.g., `Random` static instance, eliminated over-used Function) + DRY+KISS on `ShutdownTaskTest` + deleted some dead code
pelaezryan
reviewed
Mar 21, 2023
| /** | ||
| * @deprecated unused; to be removed in a "major" version bump | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Should we do this for bufferSize and recordsPublisher as well? Both those properties aren't in use either.
pelaezryan
reviewed
Mar 21, 2023
| verify(shardRecordProcessor, never()).leaseLost(any(LeaseLostInput.class)); | ||
| } | ||
|
|
||
| private Lease setupLease(final String leaseKey, final Collection<String> parentShardIds) throws Exception { |
There was a problem hiding this comment.
Nit: While creating new methods and the information is fresh, would recommend that method descriptions be added.
pelaezryan
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Added metrics in
ShutdownTaskfor scenarios when parent leases are missing.ShutdownTask(e.g.,Randomstatic instance, eliminated over-used Function)ShutdownTaskTestBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.