Minimize race in PSSM to optimize shard sync calls #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenylee-aws
force-pushed
the
shardsync2
branch
from
829ae2a to
4cc1754
Compare
furq-aws
previously approved these changes
Apr 10, 2023
stair-aws
previously approved these changes
Apr 11, 2023
...nesis-client/src/main/java/software/amazon/kinesis/coordinator/PeriodicShardSyncManager.java
Outdated
Show resolved
Hide resolved
stair-aws
approved these changes
Apr 11, 2023
chenylee-aws
changed the title
chenylee-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There exists a race condition between
PeriodicShardSyncManager (PSSM)andScheduleras reads and writes can happen concurrently in the respective threads. This would cause unnecessary shard syncs for example whenPSSMis initiated at the same time as theSchedulerthe streamToLease map is filtered based on the previous snapshot of thecurrentStreamConfigMapwhich tricks thePSSMinto believing that there is no leases for the newly added streams that already have leases.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.