Feature/multiple cred providers #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namoDB, and CloudWatch. This is needed when accessing a cross-account Kineses stream using an assumed role.
pfifer
suggested changes
Oct 4, 2016
| @@ -329,6 +329,29 @@ public void testWithAWSCredentialsFailed() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testWithDifferentAWSCredentialsForDynamoDBAndCloudWatch() { | |||
There was a problem hiding this comment.
This test appears to succeed with the current code. It might make sense to test with different class names for each credential provider. The credential decoder has the ability to load custom class names.
There was a problem hiding this comment.
@pfifer Yes my tests were terrible. Sorry about that. How are these?
|
Looks like the tests failed due to a race condition that I haven't been able to track down. Thanks for sending this PR. I just need one final confirmation, before I can merge this. Please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
@rgfindl this pull request is really helpful! |
|
Yes, you can use, modify, copy, and redistribute this contribution. Thanks! |
pfifer
approved these changes
Oct 14, 2016
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Nov 3, 2016
* General
* Allow disabling shard synchronization at startup.
* Applications can disable shard synchronization at startup. Disabling shard synchronization can application startup times for very large streams.
* [PR awslabs#102](awslabs#102)
* Applications can now request a graceful shutdown, and record processors that implement the IShutdownNotificationAware will be given a chance to checkpoint before being shutdown.
* This adds a [new interface](https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/interfaces/v2/IShutdownNotificationAware.java), and a [new method on Worker](https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/Worker.java#L539).
* [PR awslabs#109](awslabs#109)
* Solves [Issue awslabs#79](awslabs#79)
* MultiLangDaemon
* Applications can now use credential provides that accept string parameters.
* [PR awslabs#99](awslabs#99)
* Applications can now use different credentials for each service.
* [PR awslabs#111](awslabs#111)
pfifer
added a commit
that referenced
this pull request
Nov 3, 2016
* General
* Allow disabling shard synchronization at startup.
* Applications can disable shard synchronization at startup. Disabling shard synchronization can application startup times for very large streams.
* [PR #102](#102)
* Applications can now request a graceful shutdown, and record processors that implement the IShutdownNotificationAware will be given a chance to checkpoint before being shutdown.
* This adds a [new interface](https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/interfaces/v2/IShutdownNotificationAware.java), and a [new method on Worker](https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/Worker.java#L539).
* [PR #109](#109)
* Solves [Issue #79](#79)
* MultiLangDaemon
* Applications can now use credential provides that accept string parameters.
* [PR #99](#99)
* Applications can now use different credentials for each service.
* [PR #111](#111)
|
Do any of the KCL clients (e.g. python) support this feature via config files? |
|
Sorry, I understand now. The config file entries just haven't been updated in the sample file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify different credential providers for Kinesis, DynamoDB, and CloudWatch. This is needed when accessing a cross-account Kineses stream using an assumed role. #106 will help in defining the STSAssumeRoleSessionCredentialsProvider.