Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in configuring metricsEnabledDimensions #1258

Merged

Conversation

lucienlu-aws
Copy link
Contributor

@lucienlu-aws lucienlu-aws commented Feb 20, 2024

Issue #, if available:
#692

Description of changes:
Multilang users of KCL would run into the below error when attempting to configure the metricsEnabledDimensions of the KCL through the multilang properties files

Java.lang.NoSuchMethodException: software.amazon.kinesis.metrics.MetricsConfig.metricsEnabledDimensions(java.util.HashSet)

This commit fixes the type of the field so that multilang users can configure this field like this to omit emitting WorkerIdentifier dimension metrics to CloudWatch

# By default, KCL will emit metrics for Operation, ShardId, and WorkerIdentifier dimensions
# Specify the specific dimensions to emit metrics for
metricsEnabledDimensions = Operation,ShardId

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucienlu-aws lucienlu-aws merged commit 2d76973 into awslabs:master Feb 20, 2024
1 check passed
akidambisrinivasan pushed a commit to akidambisrinivasan/amazon-kinesis-client that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants