bugfix: only update in memory lease if DDB lease renews without error

[lucienlu-aws]

Issue #, if available:

Description of changes:
There is a bug in DDBLeaseRenewer such that if DDB fails to update, the in memory lease would still be updated. This commit fixes this by reverting the update if the DDB update throws any error

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[brendan-p-lynch]

I think this might be too broad and not future proof to exceptions where we wouldn't want to roll back. It seems like there could be a problem where we catch some exception but it did update the table and we roll back in memory anyway.

[brendan-p-lynch]

I am a little bit concerned that we catch this on every exception. Is it not possible that there are exceptions that we would not want to revert the lease on? Shouldn't we only catch this if the DDB update fails?

[brendan-p-lynch]

Also even if this is the case now wouldn't it be better to define them in case another case comes along where the exception woudn't stop the lease from updating.

[lucienlu-aws]

I agree with your concern, updated to be only exceptions thrown when failing to update DDB

[brendan-p-lynch]

I see that the backward compatibility tests are failing. Approving but just want to make sure we are confident it is backward compadible before merging.

[lucienlu-aws]

Backwards compatibility tests are failing due to previous PR #1340. Will double check with owners

[lucienlu-aws]

Double checked with owner of #1340, the failures is due to internally generated code and we should be okay.