Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: debug or trace logging level now properly logs all worker loops #1371

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

lucienlu-aws
Copy link
Contributor

@lucienlu-aws lucienlu-aws commented Jul 25, 2024

Issue #, if available:

Description of changes:
The logging description for the worker states that

Logger for suppressing too much INFO logging. To avoid too much logging information Worker will output logging at
INFO level for a single pass through the main loop every minute. At DEBUG level it will output all INFO logs on every pass.

The previous implementation would only check if the info log level is enabled. However, if debug or trace logging level is enabled, info level would also be enabled since debug/trace log level is a higher log level than info and still only emit info logs every minute

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucienlu-aws lucienlu-aws merged commit 51ef718 into awslabs:v1.x Jul 26, 2024
1 check passed
@lucienlu-aws lucienlu-aws deleted the logging-bug branch July 26, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants