Exclude AWS v1 SDK from KCL Glue dependency #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenylee-aws
approved these changes
Sep 6, 2024
|
@chenylee-aws are you able to merge and release this? Or do you know of someone who can? |
lucienlu-aws
approved these changes
Oct 31, 2024
ethkatnic
added a commit
to furq-aws/amazon-kinesis-client
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude the transient dependency of AWS v1 SDK from Glue in KCL. This can be done safely, as Glue is not using this dependency for anything in the serializer-deserialzer package. Glue team confirmed we can remove this safely without impacting GSR functionalities. This issue has been bumped several times in awslabs/aws-glue-schema-registry#338 but is yet to be addressed.
Th exclusion of the transient dependency com.amazonaws:aws-java-sdk-sts enables the KCL to be fully independent of the AWS SDK v1. [Multilang pending]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.