Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for regression cause due to sleep in BlockingGetRecordsCache #256

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix for regression cause due to sleep in BlockingGetRecordsCache #256

merged 1 commit into from
Oct 24, 2017

Conversation

sahilpalvia
Copy link
Contributor

  • Removed the sleep between gets introduced in the BlockingGetRecordsCache. This is supposed to be the old code path and shouldn't have a sleep in it.
  • Removed unused variables.

Fixing BlockingGetRecordsCache by removing sleep while trying to getR…
59139c4 
…ecords. This is the old code path and didn't require any sleep.
@sahilpalvia sahilpalvia requested a review from pfifer October 23, 2017 23:59
@pfifer pfifer merged commit 73426bd into awslabs:master Oct 24, 2017
@pfifer pfifer added this to the v1.8.7 milestone Oct 24, 2017
@pfifer pfifer mentioned this pull request Oct 24, 2017
Merged
@sahilpalvia sahilpalvia deleted the prefetch-fix branch October 24, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfifer pfifer Awaiting requested review from pfifer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sahilpalvia @pfifer