Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logging for long running tasks #259

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Adding logging for long running tasks #259

merged 2 commits into from
Oct 25, 2017

Conversation

sahilpalvia
Copy link
Contributor

  • This commit contains the feature for logging long running tasks.
  • This feature can be enabled by setting the value for logWarningForTaskAfterMillis, this value is to be set in milliseconds.
  • The default value for logWarningForTaskAfterMillis is not set.
  • The test case doesn't test the log message, it makes sure that the path to the log message is reached.

@sahilpalvia sahilpalvia requested a review from pfifer October 25, 2017 22:17
@pfifer pfifer added this to the v1.8.8 milestone Oct 25, 2017
@pfifer pfifer merged commit 3de901e into awslabs:master Oct 25, 2017
@sahilpalvia sahilpalvia deleted the long-running-tasks branch October 25, 2017 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfifer pfifer Awaiting requested review from pfifer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.8
Development

Successfully merging this pull request may close these issues.
2 participants
@sahilpalvia @pfifer