Fixing issue with ResourceNotFound around SubscribeToShard #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calling onNext and onComplete if throwable is of the kind ResourceNotFound. * Adding testing for ResourceNotFound * Updating version to 2.0.1-SNAPSHOT
* Throwing exception from RecordFlow.exceptionOccured
pfifer
suggested changes
Aug 10, 2018
| .forClass(FanOutRecordsPublisher.RecordFlow.class); | ||
| ArgumentCaptor<ProcessRecordsInput> inputCaptor = ArgumentCaptor.forClass(ProcessRecordsInput.class); | ||
|
|
||
| Subscriber<ProcessRecordsInput> subscriber = spy(new Subscriber<ProcessRecordsInput>() { |
There was a problem hiding this comment.
Spies are generally not recommended, you should be able to use a mock here.
| @@ -124,9 +126,19 @@ private void errorOccurred(RecordFlow triggeringFlow, Throwable t) { | |||
| outstandingRequests = 0; | |||
|
|
|||
| try { | |||
| subscriber.onError(t); | |||
| if (t.getCause() instanceof ResourceNotFoundException) { | |||
There was a problem hiding this comment.
Can you move this into a method?
| @@ -124,9 +126,19 @@ private void errorOccurred(RecordFlow triggeringFlow, Throwable t) { | |||
| outstandingRequests = 0; | |||
|
|
|||
| try { | |||
| subscriber.onError(t); | |||
| if (t.getCause() instanceof ResourceNotFoundException) { | |||
| log.warn( | |||
There was a problem hiding this comment.
This doesn't need to be a warning, as it's handled.
added 2 commits
August 10, 2018 10:18
* Creating handleFlowError method * Using mocks instead of unnecessary spies
pfifer
suggested changes
Aug 10, 2018
| public void onComplete() { | ||
| } | ||
| }); | ||
| Subscriber<ProcessRecordsInput> subscriber = mock(Subscriber.class); |
There was a problem hiding this comment.
I would just make this an instance variable and annotate it with Mock
pfifer
approved these changes
Aug 13, 2018
pfifer
added
v2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.