Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce initialization exception handler in KCL V2 #369

Merged
merged 10 commits into from
Aug 31, 2018
Merged

Introduce initialization exception handler in KCL V2 #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5205d25
Introduce initialization exception handler in KCL V2
jiaxul Aug 15, 2018
73d3320
added javadocs for CoordinatorExceptionHandler and modified method/cl…
jiaxul Aug 16, 2018
7d1d091
Move exception handling to WorkerStateChangeListener
jiaxul Aug 16, 2018
31f2ce6
Remove WorkerState InitializationError
jiaxul Aug 17, 2018
c8404ef
make initialization failure handler function a default method in Work…
jiaxul Aug 18, 2018
fbecf73
change Exception to Throwable
jiaxul Aug 23, 2018
5f841a9
change method name and invoke position
jiaxul Aug 23, 2018
8f9f8b7
merge conflicts
jiaxul Aug 30, 2018
d52873b
change method name
jiaxul Aug 30, 2018
20209c2
Merge branch 'master' into development
jiaxul Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,9 @@ public void run() {
try {
initialize();
log.info("Initialization complete. Starting worker loop.");
} catch (RuntimeException e) {
} catch (RuntimeException e) {
log.error("Unable to initialize after {} attempts. Shutting down.", maxInitializationAttempts, e);
workerStateChangeListener.onAllInitializationAttemptsFailed(e);
shutdown();
}

Expand Down
3 changes: 3 additions & 0 deletions ...s-client/src/main/java/software/amazon/kinesis/coordinator/WorkerStateChangeListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ enum WorkerState {
}

void onWorkerStateChange(WorkerState newState);

default void onAllInitializationAttemptsFailed(Throwable e) {
}
}