Graceful handling of ReadTimeoutExceptions #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Emitting logging messages at DEBUG level for retryable exceptions * Introducing SubscribeToShardRetryableException
pfifer
suggested changes
Sep 19, 2018
...is-client/src/main/java/software/amazon/kinesis/retrieval/fanout/FanOutRecordsPublisher.java
Outdated
Show resolved
Hide resolved
...is-client/src/main/java/software/amazon/kinesis/retrieval/fanout/FanOutRecordsPublisher.java
Outdated
Show resolved
Hide resolved
| Throwable current = t; | ||
| StringBuilder builder = new StringBuilder(); | ||
| do { | ||
| if (current.getMessage() != null && current.getMessage().startsWith("Acquire operation")) { | ||
| return "AcquireTimeout"; | ||
| return new ThrowableCategory(ThrowableType.ACUIRE_TIMEOUT); |
There was a problem hiding this comment.
These should just be static instances of the ThrowableCategory as they have no local state.
...c/main/java/software/amazon/kinesis/retrieval/fanout/SubscribeToShardRetryableException.java
Outdated
Show resolved
Hide resolved
| import lombok.RequiredArgsConstructor; | ||
| import lombok.experimental.Accessors; |
There was a problem hiding this comment.
Looks like these imports were added, but not used.
There was a problem hiding this comment.
Not sure why organize imports was ignored.
* Making private ThrowableCategory class static * Creating static instances for acquiretimeout and readtimeout categories * Cleaned up imports * Renamed and moved SubscribeToShardRetryableException to RetryableRetrievalException * Renamed UNKNOWN exception type to Other
pfifer
approved these changes
Sep 19, 2018
emlyn
reviewed
Sep 20, 2018
| @@ -184,29 +200,55 @@ private void handleFlowError(Throwable t) { | |||
| } | |||
| } | |||
|
|
|||
| private String throwableCategory(Throwable t) { | |||
| private enum ThrowableType { | |||
| ACUIRE_TIMEOUT("AcquireTimeout"), READ_TIMEOUT("ReadTimeout"), OTHER("Other"); | |||
There was a problem hiding this comment.
Not that it matters too much, as it's private, but there's a typo here: ACUIRE_TIMEOUT -> ACQUIRE_TIMEOUT @sahilpalvia @pfifer
There was a problem hiding this comment.
Thanks for reporting this, we'll fix it in a later release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#399
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.