Introducing callback for DynamoDB lease table #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2018 15:01
* Introducing TableCreatorCallback for DynamoDB lease management * Introducing DoesNothingTableCreatorCallback * Intoducing TableCreatorCallback config in LeaseManagementConfig, with DoesNothingTableCreatorCallback as the default
added 2 commits
September 20, 2018 15:25
added 2 commits
September 21, 2018 15:38
* Renaming DoesNothingTableCreatorCallback to NoOpTableCreatorCallback * Making performPostTableCreation method package private * Removing newly added method to LeaseRefresher interface
pfifer
approved these changes
Sep 24, 2018
| /** | ||
| * Callback interface for interacting with the DynamoDB lease table post creation. | ||
| */ | ||
| public interface TableCreatorCallback { |
There was a problem hiding this comment.
I would annotate this with @FunctionalInterface if you intend it to be used with a lambda.
| /** | ||
| * This implementation of the TableCreatorCallback does nothing. | ||
| */ | ||
| public class NoOpTableCreatorCallback implements TableCreatorCallback { |
There was a problem hiding this comment.
I would probably make this a singleton on the TableCreatorCallback interface instead of its own class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.