Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a WorkerState of SHUT_DOWN_STARTED #457

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Conversation

jiaxul
Copy link
Contributor

@jiaxul jiaxul commented Oct 25, 2018

Issue #, if available:

Description of changes:
add a workerState of SHUT_DOWN_STARTED, so action could be taken as soon as worker shutdown is requested

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@pfifer pfifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this.

Can you please provide a unit test for the change.

@jiaxul
Copy link
Contributor Author

jiaxul commented Oct 26, 2018

unit test added

@pfifer pfifer added this to the 2.1.1 milestone Jan 24, 2019
@pfifer pfifer merged commit 8d9427e into awslabs:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants