Configurable DynamoDB BillingMode #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the CI failed once due to issues unrelated to the code changes. |
|
What do I need to do to get a review on this? Currently our team is managing the dynamo table outside of the KCL because of this limitation. @ashwing ? @Cory-Bradshaw ? @pfifer ? |
|
Thanks for working on this. Let me take a look and confirm default behavior works as expected and there aren't validation problems when providing both PAY_PER_REQUEST and provisioning levels. |
|
Thanks, sounds good. I can update this with any needed changes.
…On Tue, Nov 26, 2019 at 12:01 PM Cory-Bradshaw ***@***.***> wrote:
Thanks for working on this. Let me take a look and confirm default
behavior works as expected and there aren't validation problems when
providing both PAY_PER_REQUEST and provisioning levels.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#582?email_source=notifications&email_token=AAE2BKKRF7FEX4P3ORLD2BLQVVP7VA5CNFSM4IKFR4ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFG5MUA#issuecomment-558749264>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2BKOG4YO4XLCL4EPVPE3QVVP7VANCNFSM4IKFR4ZA>
.
|
|
Found a bug, submitting a fix. DDB table cannot be set to PAY_PER_REQUEST while specifying the provisioning levels. Adding unit and integration tests as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #489
Description of changes: Adds BillingMode to the LeaseManagementConfig so that users can leveraged the pay-per-request upon table creation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.