CW publish failiures fix #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the CW publish failures.
sahilpalvia
suggested changes
Aug 8, 2019
| } catch (CloudWatchException e) { | ||
| log.warn("Could not publish {} datums to CloudWatch", endIndex - startIndex, e); | ||
| // This needs to be blocking. Making it asynchronous leads to increased throttling. | ||
| cloudWatchClient.putMetricData(request.build()).get(PUT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
No need to add the timeout. Could you catch for specific exceptions instead of generic ones.
final AWSExceptionManager exceptionManager = new AWSExceptionManager();
exceptionManager.add(CloudWatchException.class, t -> t);
try {
try {
cloudWatchClient.putMetricData(request.build()).get();
} catch (ExecutionException e) {
throw exceptionManager.apply(e.getCause);
} catch (InterruptedException e) {
log.info("Interrupted, shutdown invoked");
}
}
catch(CloudWatchException e) {
log.warn("Exception thrown while publishing to CW", e);
} catch (Exception e) {
log.error("Unknown issue while publishing to CW", e);
}There was a problem hiding this comment.
Synced up offline. We will go ahead with timeouts.
sahilpalvia
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Making CW publish calls as blocking to reduce the throttling.
Disclosing the CW publish failures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.