Drain delivery queue to make slow consumers consume events at their pace #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasemin-amzn
suggested changes
Sep 10, 2019
| @@ -158,20 +151,26 @@ RecordFlow evictAckedEventAndScheduleNextEvent(RecordsDeliveryAck recordsDeliver | |||
| // RecordFlow of the current event that needs to be returned | |||
| RecordFlow flowToBeReturned = null; | |||
|
|
|||
| final RecordsRetrieved recordsRetrieved = recordsRetrievedContext != null ? | |||
| recordsRetrievedContext.getRecordsOrShutDownEvent() | |||
| .map(recordsEvent -> recordsEvent, shutDownEvent -> null) : null; | |||
There was a problem hiding this comment.
let's move this logic out into RecordsRetrievedContext. getRecordsRetrieved either returns null or records depending on the event type stored in the context.
| if (!recordsDeliveryQueue.isEmpty()) { | ||
| scheduleNextEvent(recordsDeliveryQueue.peek().getRecordsRetrieved()); | ||
| recordsDeliveryQueue.peek().getRecordsOrShutDownEvent() | ||
| .apply(recordsEvent -> scheduleNextEvent(recordsEvent), |
There was a problem hiding this comment.
Can this also move out into the RecordsRetrievedContext? each event would define execution action, similar to the shutdownEvent's getSubscriptionShutdownAction, and this flow would just call executeEvenAction independent of the event type.
| private final RecordFlow recordFlow; | ||
| private final Instant enqueueTimestamp; | ||
| } | ||
|
|
||
| @Getter | ||
| private static final class SubscriptionShutDownEvent { | ||
| private final Runnable subscriptionShutDownAction; |
yasemin-amzn
approved these changes
Sep 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.