Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making test cases resilient to delayed thread operations #612

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

ashwing
Copy link
Contributor

@ashwing ashwing commented Sep 19, 2019

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@micah-jaffe micah-jaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, LGTM. Some comments might be helpful to understand what these tests are doing as the code is a bit complex.

@micah-jaffe micah-jaffe merged commit c197d35 into awslabs:master Sep 19, 2019
@ashwing ashwing mentioned this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants