Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating sdk version and fixing unit tests #638

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Updating sdk version and fixing unit tests #638

merged 2 commits into from
Oct 30, 2019

Conversation

ychunxue
Copy link
Contributor

Description of changes:
Upgrade SDK version to 2.9.25. Fixed several unit tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cory-Bradshaw
Cory-Bradshaw suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@Cory-Bradshaw Cory-Bradshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a closer look at working around or removing the verifications that are being edited. Some are verifications that likely should never have been there to begin with, others are integral to the test itself and should not be loosened to any()

...t/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutConsumerRegistrationTest.java Outdated Show resolved Hide resolved
...t/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutConsumerRegistrationTest.java Outdated Show resolved Hide resolved
...t/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutConsumerRegistrationTest.java Outdated Show resolved Hide resolved
...t/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutConsumerRegistrationTest.java Outdated Show resolved Hide resolved
...lient/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutRecordsPublisherTest.java Outdated Show resolved Hide resolved
...lient/src/test/java/software/amazon/kinesis/retrieval/fanout/FanOutRecordsPublisherTest.java Outdated Show resolved Hide resolved
@Cory-Bradshaw
Copy link
Contributor

Looks good to me. Thanks for taking the time to update the unit tests!

@ychunxue ychunxue merged commit c696bc1 into awslabs:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cory-Bradshaw Cory-Bradshaw Cory-Bradshaw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ychunxue @Cory-Bradshaw