Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the new test task is scheduled beyond millisecond delay to avo… #668

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

josvijay
Copy link
Contributor

…id incorrect test failure.

Issue #, if available:

Description of changes:
Fix ShardConsumerTest unit test failures by adding sleep time as a short term workaround.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ychunxue ychunxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ychunxue ychunxue merged commit 8a01abb into awslabs:master Dec 20, 2019
joshua-kim added a commit to awslabs/amazon-kinesis-client-nodejs that referenced this pull request Jan 31, 2020
### Release 2.0.1 (January 31, 2020)

[Milestone #4](https://github.com/awslabs/amazon-kinesis-client-nodejs/milestone/4)
* Fixing bootstrap to use HTTPS
  * [PR #75](awslabs/amazon-kinesis-client#679)
* Adding support for Win32 platform
  * [PR #67](awslabs/amazon-kinesis-client#668)
* Relicensing to Apache-2.0
  * [PR #69](awslabs/amazon-kinesis-client#667)
@joshua-kim joshua-kim added this to the v2.2.8 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants