Get latest counter before attempting leaseSteal to ensure leaseSteal succeeds #765
Conversation
Renjuju
changed the title
| @@ -48,6 +47,7 @@ | |||
| import software.amazon.kinesis.metrics.MetricsLevel; | |||
| import software.amazon.kinesis.metrics.MetricsScope; | |||
| import software.amazon.kinesis.metrics.MetricsUtil; | |||
| import static software.amazon.kinesis.common.CommonCalculations.*; | |||
There was a problem hiding this comment.
Avoid wildcard in packages
| private final MetricsFactory metricsFactory; | ||
|
|
||
| private final double RENEWAL_SLACK_PERCENTAGE = 0.5; |
| try { | ||
| return leaseRefresher.getLease(lease.leaseKey()); | ||
| } catch (DependencyException | InvalidStateException | ProvisionedThroughputException e) { | ||
| log.debug("Unable to retrieve the current lease, defaulting to existing lease", e); |
There was a problem hiding this comment.
Also give more context on when this failed. Like while we tried to update the stale leases
There was a problem hiding this comment.
Left few minor comments. I verified the comments in ashwing#94, addressed
|
Thanks I need to go over the PR one more time. Can you do a functional test for this change and update the CR? Yu Zeng 10:33 AM Ashwin Giridharan 10:34 AM 10:35 Yu Zeng 10:37 AM |
Changes
Tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.