Fixing bug where ShardFilter parameter for ListShards was being passe… #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in for paginated calls. This resulted in a bug where all calls for ListShards when initializing the lease table would fail, since Kinesis only requires the NextToken parameter when making paginated calls.
yatins47
reviewed
Feb 19, 2021
| if (StringUtils.isEmpty(nextToken)) { | ||
| request = request.streamName(streamIdentifier.streamName()); |
There was a problem hiding this comment.
Do we need to validate filter is not empty and fail directly with a message if it is ?
There was a problem hiding this comment.
We don't need to, if a filter is null then this is equivalent to an ordinary listShards call since it uses same API but ShardFilter parameter is optional.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This resulted in a bug where all calls for ListShards when initializing
the lease table would fail, since Kinesis only requires the NextToken
parameter when making paginated calls.
Testing:
Created a large stream which was enough to cause pagination; tried to initiate a shard sync with an empty lease table (breaks as expected):
After the change, we see that the lease table is created as expected with all shards.
New logging:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.