Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence warning when there are no stale streams to delete #794

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

tiaanl
Copy link
Contributor

@tiaanl tiaanl commented Mar 10, 2021

A warning is logged when stale steams are to be deleted, but the log is still emitted even if the map of streams to delete is empty. This just silences the warning as it is emitted at least a few times per minute.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@antoshen antoshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, we will merge the PR and the change will be released in 1-2 months.

@antoshen antoshen merged commit 7f18330 into awslabs:master Jun 22, 2021
@AvinashChowdary AvinashChowdary added this to the v2.3.6 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants