Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat unassigned leases (as well as expired ones) as available-to-be-taken #848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 18, 2022

  1. Treat unassigned leases (as well as expired ones) as available-to-be-…

    …taken
    
    If a lease is 'unassigned' (it has no lease owner) then it should be
    considered available for taking in `DynamoDBLeaseTaker`. Prior to this
    change, the only ways `DynamoDBLeaseTaker` could take leases for a
    scheduler was either by incremental lease stealing, or waiting for the
    lease to expire by not having been updated in `failoverTimeMillis` - which
    could be slow if `failoverTimeMillis` was set reasonably high (with it set
    to just 30s, I've seen new instances take over 3 minutes to take all leases
    from old instances in a deployment).
    
    This would be one half of the a fix for
    awslabs#845 - the other
    half of the fix is invoking `evictLease()` (setting the lease owner to
    null) on graceful shutdown of a scheduler.
    rtyley committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    f9d5077 View commit details
    Browse the repository at this point in the history