Accept camel-case properties for producer configuration #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our property files use camelCase for a lot of our applications, and I noticed that the KinesisProducerConfiguration fromProperties method is doing a case sensitive search. Updated the method / property equality check to ignore case.
|
If it makes sense to include other cases like snake__case and spinal-case, i'd be happy to update that in this PR. |
emckissick
changed the title
…mel-case # Conflicts: # java/amazon-kinesis-producer/src/test/java/com/amazonaws/services/kinesis/producer/KinesisProducerConfigurationTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our property files use camelCase for a lot of our applications, and I
noticed that the KinesisProducerConfiguration fromProperties method is
doing a case sensitive search. This called us to change our applications properties specifically for Kinesis fields. Which is not ideal. Updated the method / property equality
check to ignore case.