[BUG] globalThreadSleep linkerror

[thomas-roos]

When building shared version. This is missing

Index: git/CMakeLists.txt
===================================================================
--- git.orig/CMakeLists.txt
+++ git/CMakeLists.txt
@@ -221,7 +221,7 @@ if(BUILD_GSTREAMER_PLUGIN)
   target_link_libraries(gstkvssink PRIVATE ${GST_APP_LIBRARIES} KinesisVideoProducer)

   add_executable(kvssink_gstreamer_sample samples/kvssink_gstreamer_sample.cpp)
-  target_link_libraries(kvssink_gstreamer_sample ${GST_APP_LIBRARIES} KinesisVideoProducer)
+  target_link_libraries(kvssink_gstreamer_sample ${GST_APP_LIBRARIES} KinesisVideoProducer kvspic)

   add_executable(kvs_gstreamer_sample samples/kvs_gstreamer_sample.cpp)
   target_link_libraries(kvs_gstreamer_sample ${GST_APP_LIBRARIES} KinesisVideoProducer kvspic)

[stefankiesz]

Hi @thomas-roos,

In Producer C, we publicly link kvspic to cproducer:

target_link_libraries(cproducer PUBLIC kvsCommonCurl kvspic)

And here in Producer C++, cproducer is publicly linked to KinesisVideoProducer:

target_link_libraries(
  KinesisVideoProducer
  PUBLIC kvsCommonCurl
         cproducer
         ${Log4cplus}
         ${LIBCURL_LIBRARIES})

So it seems linking both KinesisVideoProducer and kvspic to the sample would be redundant. Did you experience any issue that was resolved with this change?

[thomas-roos]

Yes, getting this error:
error.txt
When building without this patch here: https://github.com/aws4embeddedlinux/meta-aws/blob/8575c18e1d18caa44777b7b645a025dbd22f10eb/recipes-sdk/amazon-kvs-producer-sdk/amazon-kvs-producer-sdk-cpp_3.4.2.bb#L19