Use batch payload delete, and properly chain deletes for async #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Two issues in the new async support were bothering me:
This pull request solves both problems by performing the delete-from-S3 and delete-from-SQS operations in the same order for both sync and async code, and by properly chaining them the same way for both.
Note that this new code makes use of a new feature in payload offloading, which deletes a batch of offloaded pointers from the store. This new feature is in this pull request: awslabs/payload-offloading-java-common-lib-for-aws#57
Because that feature is only proposed right now, I am creating this as a draft PR for the time being.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.