Improve logging #190
Merged
Improve logging #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes string concatenation in logging statements where possible, in favor of format-based logging messages.
At present, for every JMS message sent there are the following 2 statements logged at info level: - messageId in SQSMessageProducer#sendInternal - shutting down executor in SQSSession#doClose These result in excessive logging for systems that product a lot of JMS messages and are really better fit for debug level. Additionally, SQSMessageConsumer#doClose also has an equivalent logging statement to one in SQSSession#doClose. Finally, SQSSessionCallbackScheduler#run contains logging statement that logs exception at info level, which is better suited for warn level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits that improve logging.
Avoid string concatenation in logging statements
This commit removes string concatenation in logging statements where
possible, in favor of format-based logging messages.
Tweak logging statement levels
At present, for every JMS message sent there are the following 2
statements logged at info level:
These result in excessive logging for systems that product a lot of JMS
messages and are really better fit for debug level.
Additionally, SQSMessageConsumer#doClose also has an equivalent logging
statement to one in SQSSession#doClose.
Finally, SQSSessionCallbackScheduler#run contains logging statement that
logs exception at info level, which is better suited for warn level.