Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flakey Linter Action #48

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix Flakey Linter Action #48

merged 3 commits into from
Mar 26, 2024

Conversation

forestmvey
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

Fix golangci-lint action that usually fails on first execution. Linter action has timeout errors so I increased the timeout to 2 mins which has fixed the problem. I also upgraded the other action versions to avoid the node deprecation warnings.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

forestmvey and others added 3 commits March 26, 2024 14:19
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
@forestmvey
Copy link
Contributor Author

Changes have already gone through code review on downstream repository, and therefore I'm merging the changes.

@forestmvey forestmvey merged commit 0f31097 into awslabs:main Mar 26, 2024
6 checks passed
@forestmvey forestmvey deleted the integ-fix-flakey-linter-action branch March 26, 2024 22:45
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
* Upgrading actions to latest versions.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Increasing timeout for linter

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
* Upgrading actions to latest versions.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Increasing timeout for linter

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
* Upgrading actions to latest versions.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Increasing timeout for linter

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
* Upgrading actions to latest versions.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Increasing timeout for linter

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant