Skip to content

Commit

Permalink
Merge pull request #282 from alex-chew/fix-dev-mode-index-html
Browse files Browse the repository at this point in the history
Fix dev mode index html
  • Loading branch information
echo-bravo-yahoo authored Jun 26, 2019
2 parents dbe928a + 11ee9f9 commit a3f9d2d
Show file tree
Hide file tree
Showing 3 changed files with 71 additions and 26 deletions.
2 changes: 1 addition & 1 deletion cloudformation/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Parameters:

DevelopmentMode:
Type: String
Description: Enabling this weakens security features (OAI, SSL, site S3 bucket with public read ACLs, Cognito callback verification, CORS, etc.) for easier development. Do not enable this in production! Additionally, do not update a stack that was previously in development mode to be a production stack; instead, make a new stack that has never been in development mode.
Description: Enabling this weakens security features (OAI, SSL, site S3 bucket with public read ACLs, Cognito callback verification, CORS, etc.) for easier development. It also breaks frontend routing (except to /index.html), including deep linking and page refresh. Do not enable this in production! Additionally, do not update a stack that was previously in development mode to be a production stack; instead, make a new stack that has never been in development mode.
Default: 'false'

Conditions:
Expand Down
92 changes: 67 additions & 25 deletions dev-portal/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions dev-portal/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ class App extends React.Component {
<GlobalModal />
<Switch>
<Route exact path="/" component={Home} />
<Route exact path="/index.html" component={() =>
<Redirect to="/"/>
} />
<Route path="/getting-started" component={GettingStarted} />
<Route path="/dashboard" component={Dashboard} />
<AdminRoute path="/admin" component={Admin} />
Expand Down

0 comments on commit a3f9d2d

Please sign in to comment.