Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev mode index html #282

Merged
merged 3 commits into from
Jun 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudformation/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Parameters:

DevelopmentMode:
Type: String
Description: Enabling this weakens security features (OAI, SSL, site S3 bucket with public read ACLs, Cognito callback verification, CORS, etc.) for easier development. Do not enable this in production! Additionally, do not update a stack that was previously in development mode to be a production stack; instead, make a new stack that has never been in development mode.
Description: Enabling this weakens security features (OAI, SSL, site S3 bucket with public read ACLs, Cognito callback verification, CORS, etc.) for easier development. It also breaks frontend routing (except to /index.html), including deep linking and page refresh. Do not enable this in production! Additionally, do not update a stack that was previously in development mode to be a production stack; instead, make a new stack that has never been in development mode.
Default: 'false'

Conditions:
Expand Down
92 changes: 67 additions & 25 deletions dev-portal/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions dev-portal/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ class App extends React.Component {
<GlobalModal />
<Switch>
<Route exact path="/" component={Home} />
<Route exact path="/index.html" component={() =>
<Redirect to="/"/>
} />
<Route path="/getting-started" component={GettingStarted} />
<Route path="/dashboard" component={Dashboard} />
<AdminRoute path="/admin" component={Admin} />
Expand Down