Tweak the UI and streamline the implementation in places, resolve various initial bugs #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 6, 2020 14:38
My editor was misinterpreting it as the root and not properly applying the rules from the parent.
- CloudFormation was trying to overwrite existing tables - The `accounts/*` routes weren't reaching far enough to get the utils module
The "Search APIs" button looked more like an API than a separate page, so I moved it up and made it as a header to reduce the potential for confusion.
ghost
marked this pull request as ready for review
ghost
requested review from
a-tan,
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
added 8 commits
March 11, 2020 13:55
Express doesn't play well with promises, and so this should help result in far fewer *unhandled* promise rejections (making them handled and more properly reported).
ghost
changed the title
skylarbemus
approved these changes
Mar 13, 2020
jiyou95
approved these changes
Mar 16, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: The commits explain the PR well enough, and where the commit title isn't sufficient, the commit message itself should fill in the gaps.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.