Fix asset uploader, tweak backend and dev setup #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
meaisiah-assets-fix
branch
from
2da134c to
2871e5b
Compare
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
skylarbemus
approved these changes
Mar 24, 2020
MynockSpit
reviewed
Mar 26, 2020
added 3 commits
March 26, 2020 13:25
Also, rip out some no-longer-used callback URLs
ghost
force-pushed
the
meaisiah-assets-fix
branch
from
2871e5b to
9dad8d3
Compare
MynockSpit
reviewed
Mar 30, 2020
| res.status(500).json(err) | ||
| }) | ||
| const feedback = await feedbackController.fetchFeedback() | ||
| res.status(200).json(feedback) | ||
| } |
There was a problem hiding this comment.
No 5xx needed or is this caught elsewhere?
There was a problem hiding this comment.
It's caught here, and uncaught errors and rejections are forwarded as 5xx errors by AWS Lambda itself (and logged appropriately).
MynockSpit
approved these changes
Mar 30, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.