Last-minute pre-release fixes #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 30, 2020 22:17
Also, remove some useless timeouts.
This does five things: 1. Ensure all lambda requests wait for the auth token to be set before continuing. All the backend methods currently require authorization to execute, but none of the front-end calls were waiting on that. 2. I previously changed `stage` to `apiStage`, and this caused a lot of breakage. The lack of clear types only made this more difficult, as it was consistently not clear at a glance what of the 3-ish different representations APIs have at different places within the app (both in front end, backend, and in the catalog). This fixes that in all places. 3. Consume errors from the request as a *blob* and not a *JSON object*. 4. Move the `initApiGatewayClient` in `init` to the `else`, as the auth flow for when a valid JWT already exists also automatically attempts re-authentication from that token, and so it's unnecessary to always initialize with a blank client. (Plus, blank clients are almost never actually used in practice anyways.) 5. SwaggerUI is now only loaded whenever the element is guaranteed to exist. This was mainly a step in fault tolerance, as it was throwing due to other bugs and was making them a little more difficult to troubleshoot.
Also, tweak a few styles
ghost
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
added 5 commits
March 30, 2020 22:33
The comment was only on one of them, and now that there's a lot more of them, the comment and its location needed to be updated to better reflect that.
Also remove several duplicate packages in `dev-portal/`.
MynockSpit
approved these changes
Mar 31, 2020
skylarbemus
approved these changes
Mar 31, 2020
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
See the commits for details. With a few exceptions, they're all atomic.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.