Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 21] Adding timezone support #139

Merged
merged 5 commits into from
May 7, 2020
Merged

[ISSUE 21] Adding timezone support #139

merged 5 commits into from
May 7, 2020

Conversation

soojinj
Copy link
Contributor

@soojinj soojinj commented Apr 14, 2020

Issue #, if available:
#21

Description of changes:
SDK side of changes to support timezone

v2 of #130

@soojinj soojinj requested review from avirtuos and atennak1 and removed request for avirtuos April 14, 2020 22:33
@soojinj soojinj mentioned this pull request Apr 15, 2020
Closed
avirtuos
avirtuos requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@avirtuos avirtuos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only 1 changed requested. Let me know once you review it and I'll give a quick follow up look.

Also, what is the status of the Presto side changes? Can you Chime me the CR when you get a sec.

@avirtuos
Copy link
Contributor

Ok, looks like only remaining things from my perspective are:

  1. Please add new documentation about this type to the federation-sdk readme
  2. Do not push this until the corresponding Athena side changes are shipped.

atennak1
atennak1 previously approved these changes Apr 20, 2020
View reviewed changes
@soojinj
Copy link
Contributor Author

soojinj commented May 6, 2020

testing:
select isodatetimeest1, isodatetimeest1 at time zone 'UTC' from sometable;
isodatetimeest1 | _col1
--------------------------------+-----------------------------
2015-12-21 17:42:34.000 UTC | 2015-12-21 17:42:34.000 UTC
2015-12-21 17:42:34.000 -03:00 | 2015-12-21 20:42:34.000 UTC
2015-12-21 17:42:34.000 -05:00 | 2015-12-21 22:42:34.000 UTC

select isodatetimeest1, isodatetimeest1 at time zone 'UTC' from sometable WHERE isodatetimeest1 < timestamp '2015-12-21 18:42:34 UTC';
isodatetimeest1 | _col1
-----------------------------+-----------------------------
2015-12-21 17:42:34.000 UTC | 2015-12-21 17:42:34.000 UTC
(1 row)

@avirtuos avirtuos merged commit 2c530c5 into awslabs:master May 7, 2020
@avirtuos
Copy link
Contributor

avirtuos commented May 7, 2020

Nice job @soojinj , thanks for powering through this.

abhishekpradeepmishra pushed a commit to abhishekpradeepmishra/aws-athena-query-federation that referenced this pull request Nov 1, 2021
@iansrobinson
Improve connection handling and retries in BatchUtils (awslabs#139)
ddf5842 
* Updated readme

* Improve connection pooling in batch utils

* Update batch utils

* Improve retries in batch utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avirtuos avirtuos avirtuos approved these changes

@atennak1 atennak1 atennak1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soojinj @avirtuos @atennak1