Implement SSOCredentialsProvider #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
reviewed
Mar 31, 2023
| @@ -292,3 +294,37 @@ enum aws_retry_error_type aws_credentials_provider_compute_retry_error_type(int | |||
|
|
|||
| return error_type; | |||
| } | |||
|
|
|||
| struct aws_profile_collection *aws_load_profile_collection_from_config_file( | |||
There was a problem hiding this comment.
should this function be moved to aws/sdkutils/aws_profile.h?
There was a problem hiding this comment.
This is just a util function which is calling two functions from aws_profile.h with some common default values for auth. I would rather not make this public.
TingDaoK
approved these changes
Apr 4, 2023
waahm7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #164
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.