Skip to content

Fix warnings found by the Undefined Behavior Sanitizer #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjosv wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix warnings found by the Undefined Behavior Sanitizer #274

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b2d25e
Fix warnings found by the Undefined Behavior Sanitizer
bjosv Aug 7, 2025
2f7ade4
Merge branch 'main' into ubsan-fixes
bjosv Oct 29, 2025
f56ded6
Merge branch 'main' into ubsan-fixes
bjosv Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions source/aws_signing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ static struct aws_byte_cursor s_amz_security_token_param_name;
static struct aws_byte_cursor s_amz_expires_param_name;
static struct aws_byte_cursor s_amz_region_set_param_name;

static bool s_name_eq_ignore_case(const void *a, const void *b) {
const struct aws_byte_cursor *a_cursor = a;
const struct aws_byte_cursor *b_cursor = b;
return aws_byte_cursor_eq_ignore_case(a_cursor, b_cursor);
}

/*
* Build a set of library-static tables for quick lookup.
*
Expand All @@ -112,7 +118,7 @@ int aws_signing_init_signing_tables(struct aws_allocator *allocator) {
allocator,
10,
aws_hash_byte_cursor_ptr_ignore_case,
(aws_hash_callback_eq_fn *)aws_byte_cursor_eq_ignore_case,
s_name_eq_ignore_case,
NULL,
NULL)) {
return AWS_OP_ERR;
Expand Down Expand Up @@ -168,7 +174,7 @@ int aws_signing_init_signing_tables(struct aws_allocator *allocator) {
allocator,
10,
aws_hash_byte_cursor_ptr_ignore_case,
(aws_hash_callback_eq_fn *)aws_byte_cursor_eq_ignore_case,
s_name_eq_ignore_case,
NULL,
NULL)) {
return AWS_OP_ERR;
Expand Down Expand Up @@ -207,7 +213,7 @@ int aws_signing_init_signing_tables(struct aws_allocator *allocator) {
allocator,
10,
aws_hash_byte_cursor_ptr_ignore_case,
(aws_hash_callback_eq_fn *)aws_byte_cursor_eq_ignore_case,
s_name_eq_ignore_case,
NULL,
NULL)) {
return AWS_OP_ERR;
Expand Down