fix test

awslabs · Sep 29, 2023 · 6391d34 · 6391d34
1 parent 1940832
commit 6391d34
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 46 deletions.
diff --git a/source/windows/bcrypt_rsa.c b/source/windows/bcrypt_rsa.c
@@ -75,7 +75,7 @@ static int s_reinterpret_bc_error_as_crt(NTSTATUS error, const char *function_na
 
 on_error:
     AWS_LOGF_ERROR(
-        AWS_LS_CAL_RSA, "%s() failed. returned: %d aws_error:%s", function_name, error, aws_error_name(crt_error));
+        AWS_LS_CAL_RSA, "%s() failed. returned: %X aws_error:%s", function_name, error, aws_error_name(crt_error));
 
     return aws_raise_error(crt_error);
 }

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -85,7 +85,6 @@ add_test_case(rsa_verify_signing_pss_sha256)
 add_test_case(rsa_decrypt_pkcs1)
 add_test_case(rsa_decrypt_oaep256)
 add_test_case(rsa_decrypt_oaep512)
-add_test_case(rsa_neg_modulus_pub_key)
 
 add_test_case(aes_cbc_NIST_CBCGFSbox256_case_1)
 add_test_case(aes_cbc_NIST_CBCVarKey256_case_254)

diff --git a/tests/rsa_test.c b/tests/rsa_test.c
@@ -423,7 +423,8 @@ static int s_rsa_signing_roundtrip_helper(
     /*short buffer should fail*/
     struct aws_byte_buf signature_short;
     ASSERT_SUCCESS(aws_byte_buf_init(&signature_short, allocator, 5));
-    ASSERT_ERROR(AWS_ERROR_SHORT_BUFFER, aws_rsa_key_pair_sign_message(key_pair_private, algo, hash_cur, &signature_short));
+    ASSERT_ERROR(AWS_ERROR_SHORT_BUFFER,
+            aws_rsa_key_pair_sign_message(key_pair_private, algo, hash_cur, &signature_short));
 
     struct aws_byte_cursor signature_cur = aws_byte_cursor_from_buf(&signature);
     ASSERT_TRUE(aws_byte_cursor_starts_with(&signature_cur, &prefix));
@@ -688,46 +689,3 @@ static int s_rsa_public_pkcs1_der_parsing(struct aws_allocator *allocator, void
     return AWS_OP_SUCCESS;
 }
 AWS_TEST_CASE(rsa_public_pkcs1_der_parsing, s_rsa_public_pkcs1_der_parsing);
-
-
-static int s_rsa_neg_modulus_pub_key(struct aws_allocator *allocator, void *ctx) {
-    (void)ctx;
-
-    aws_cal_library_init(allocator);
-
-    uint8_t neg_modulus_key[] = {
-        0x30, 0x82, 0x01, 0x09, 0x02, 0x82, 0x01, 0x00, 0x96, 0xa6, 0x2e, 0x9c,
-        0x4e, 0x6a, 0xc3, 0xcc, 0xcd, 0x8f, 0x70, 0xc3, 0x55, 0xbf, 0x5e, 0x9c,
-        0xd4, 0xf3, 0x17, 0xc3, 0x97, 0x70, 0xae, 0xdf, 0x12, 0x5c, 0x15, 0x80,
-        0x03, 0xef, 0x2b, 0x18, 0x9d, 0x6a, 0xcb, 0x52, 0x22, 0xc1, 0x81, 0xb8,
-        0x7e, 0x61, 0xe8, 0x0f, 0x79, 0x24, 0x0f, 0x82, 0x70, 0x24, 0x4e, 0x29,
-        0x20, 0x05, 0x54, 0xeb, 0xd4, 0xa9, 0x65, 0x59, 0xb6, 0x3c, 0x75, 0x95,
-        0x2f, 0x4c, 0xf6, 0x9d, 0xd1, 0xaf, 0x5f, 0x14, 0x14, 0xe7, 0x25, 0xea,
-        0xa5, 0x47, 0x5d, 0xc6, 0x3e, 0x28, 0x8d, 0xdc, 0x54, 0x87, 0x2a, 0x7c,
-        0x10, 0xe9, 0xc6, 0x76, 0x2d, 0xe7, 0x79, 0xd8, 0x0e, 0xbb, 0xa9, 0xac,
-        0xb5, 0x18, 0x98, 0xd6, 0x47, 0x6e, 0x06, 0x70, 0xbf, 0x9e, 0x82, 0x25,
-        0x95, 0x4e, 0xfd, 0x70, 0xd7, 0x73, 0x45, 0x2e, 0xc1, 0x1f, 0x7a, 0x9a,
-        0x9d, 0x60, 0xc0, 0x1f, 0x67, 0x06, 0x2a, 0x4e, 0x87, 0x3f, 0x19, 0x88,
-        0x69, 0x64, 0x4d, 0x9f, 0x75, 0xf5, 0xd3, 0x1a, 0x41, 0x3d, 0x35, 0x17,
-        0xb6, 0xd1, 0x44, 0x0d, 0x25, 0x8b, 0xe7, 0x94, 0x39, 0xb0, 0x7c, 0xaf,
-        0x3e, 0x6a, 0xfa, 0x8d, 0x90, 0x21, 0x0f, 0x8a, 0x43, 0x94, 0x37, 0x7c,
-        0x2a, 0x15, 0x4c, 0xa0, 0xfa, 0xa9, 0x2f, 0x21, 0xa6, 0x6f, 0x8e, 0x2f,
-        0x89, 0xbc, 0xbb, 0x33, 0xf8, 0x31, 0xfc, 0xdf, 0xcd, 0x68, 0x9a, 0xbc,
-        0x75, 0x06, 0x95, 0xf1, 0x3d, 0xef, 0xca, 0x76, 0x27, 0xd2, 0xba, 0x8e,
-        0x0e, 0x1c, 0x43, 0xd7, 0x70, 0xb9, 0xc6, 0x15, 0xca, 0xd5, 0x4d, 0x87,
-        0xb9, 0xd1, 0xae, 0xde, 0x69, 0x73, 0x00, 0x2a, 0x97, 0x51, 0x4b, 0x30,
-        0x01, 0xc2, 0x85, 0xd0, 0x05, 0xcc, 0x2e, 0xe8, 0xc7, 0x42, 0xe7, 0x94,
-        0x51, 0xe3, 0xf5, 0x19, 0x35, 0xdc, 0x57, 0x96, 0xe7, 0xd9, 0xb4, 0x49,
-        0x02, 0x03, 0x01, 0x00, 0x01,
-    };
-
-    struct aws_rsa_key_pair *pub_key = aws_rsa_key_pair_new_from_public_key_pkcs1(allocator, 
-        aws_byte_cursor_from_array(neg_modulus_key, AWS_ARRAY_SIZE(neg_modulus_key)));
-
-    ASSERT_NULL(pub_key);
-
-    aws_cal_library_clean_up();
-
-    return AWS_OP_SUCCESS;
-}
-AWS_TEST_CASE(rsa_neg_modulus_pub_key, s_rsa_neg_modulus_pub_key);