Make AES GCM more consistent cross platform #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Jun 20, 2024
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
graebm
approved these changes
Jun 20, 2024
source/windows/bcrypt_aes.c
Outdated
| int ret_val = s_aes_default_encrypt(cipher, &final_cur, out); | ||
| int ret_val = AWS_OP_SUCCESS; | ||
| if (final_cur.len > 0) { | ||
| s_aes_default_encrypt(cipher, &final_cur, out); |
There was a problem hiding this comment.
still not checking result here
There was a problem hiding this comment.
ugh, im dumb. stashed the fix to merge in auto merges and never poped it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Warning Backwards Incompatible change: moved gcm tag out of the constructor into a separate setter, since it was leading to a whole bunch of annoying corner cases, that was not handled consistently cross platform. And arguably having tag as a separate setter is a bit cleaner design, since we already complicate logic, by abstracting away encryptor vs decryptor
Outside of that, changes are mostly extra tests and corresponding changes to make everything consistent cross platform
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.