check env null

awslabs · Jul 31, 2024 · 6398563 · 6398563
1 parent 0a98aa0
commit 6398563
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/aws/common/environment.h b/include/aws/common/environment.h
@@ -20,7 +20,7 @@ struct aws_string;
 AWS_EXTERN_C_BEGIN
 
 /*
- * Get the value of an environment variable.  If the variable is not set, the output string will be set to NULL.
+ * Get the value of an environment variable.  If the variable is not set or is empty, the output string will be set to NULL.
  * Not thread-safe
  */
 AWS_COMMON_API

diff --git a/source/posix/environment.c b/source/posix/environment.c
@@ -14,7 +14,7 @@ int aws_get_environment_value(
     struct aws_string **value_out) {
 
     const char *value = getenv(aws_string_c_str(variable_name));
-    if (value == NULL) {
+    if (value == NULL || value[0]=='\0') {
         *value_out = NULL;
         return AWS_OP_SUCCESS;
     }

diff --git a/source/windows/environment.c b/source/windows/environment.c
@@ -24,7 +24,7 @@ int aws_get_environment_value(
 #    pragma warning(pop)
 #endif
 
-    if (value == NULL) {
+    if (value == NULL || value[0] == '\0') {
         *value_out = NULL;
         return AWS_OP_SUCCESS;
     }