add a query string helper from byte cursor directly #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 83.30% 83.31% +0.01%
==========================================
Files 56 56
Lines 5804 5808 +4
==========================================
+ Hits 4835 4839 +4
Misses 969 969 ☔ View full report in Codecov by Sentry. |
graebm
reviewed
Dec 23, 2023
source/uri.c
Outdated
| bool aws_uri_query_string_next_param(const struct aws_uri *uri, struct aws_uri_param *param) { | ||
| return aws_query_string_next_param(uri->query_string, param); | ||
| } | ||
|
|
||
| int aws_uri_query_string_params(const struct aws_uri *uri, struct aws_array_list *out_params) { | ||
| struct aws_uri_param param; |
There was a problem hiding this comment.
if possible, just have aws_uri_query_string_params() call into aws_query_string_params()
include/aws/common/uri.h
Outdated
| * 2) Blank entries are skipped. | ||
| * Example: The only param in query string "&&a=b" is key="a" value="b" | ||
| */ | ||
| AWS_COMMON_API bool aws_query_string_next_param(struct aws_byte_cursor query_string, struct aws_uri_param *param); |
There was a problem hiding this comment.
in that other PR how do you plan to go from path_and_query to just query? Does that necessitate another helper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.